Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Mat 7914 patient characteristic expired #766

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Mat 7914 patient characteristic expired #766

merged 2 commits into from
Nov 20, 2024

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Nov 20, 2024 •
edited
Loading

MADiE PR

Jira Ticket: MAT-7914
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner November 20, 2024 14:32
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.01% ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ecac28f) 5708 5037 88.24%
Head commit (781c1c0) 5714 (+6) 5043 (+6) 88.26% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#766) 9 9 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.34%. Comparing base (ecac28f) to head (781c1c0).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...mentsTab/Demographics/DemographicsSectionConst.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #766   +/-   ##
========================================
  Coverage    83.34%   83.34%           
========================================
  Files          205      205           
  Lines         6195     6201    +6     
  Branches      1348     1349    +1     
========================================
+ Hits          5163     5168    +5     
  Misses         707      707           
- Partials       325      326    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@sb-cecilialiu sb-cecilialiu merged commit 433b371 into develop Nov 20, 2024
13 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-7914_PatientCharacteristicExpired branch November 20, 2024 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adongare adongare adongare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sb-cecilialiu @adongare